Fix video/poster assets: use GitHub LFS media URLs#254
Merged
Conversation
The deploy workflow doesn't fetch LFS files, so the static site was serving LFS pointer files instead of actual video/image content. Point directly at media.githubusercontent.com URLs instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+29
to
+30
| <video controls preload="metadata" poster="https://media.githubusercontent.com/media/futuresearch/everyrow-sdk/main/docs-site/public/videos/setup-claude-web-poster.jpg" style={{display: 'block', width: '100%', borderRadius: '8px', border: '1px solid #e5e7eb'}}> | ||
| <source src="https://media.githubusercontent.com/media/futuresearch/everyrow-sdk/main/docs-site/public/videos/setup-claude-web.mp4" type="video/mp4" /> |
There was a problem hiding this comment.
Bug: New video URLs use an incorrect path format (main/ instead of refs/heads/main/), which will cause the CI link checker script to fail and block deployment.
Severity: CRITICAL
Suggested Fix
Update the new video and poster URLs in docs/mcp-server.mdx to use the refs/heads/main/ path instead of main/. This will align them with the existing pattern and allow the check-links.py script to correctly validate them.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/mcp-server.mdx#L29-L30
Potential issue: The pull request introduces new URLs for video assets using the
`.../main/...` path format. The continuous integration link checker script,
`check-links.py`, is configured with a `REPO_LFS_PREFIX` that expects a
`.../refs/heads/main/...` path to validate local files. Since the new URLs do not match
this prefix, the script will classify them as unrecognized external links. This will
trigger an error during the link check step, causing the deployment workflow to fail.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/docs/videos/references withmedia.githubusercontent.comURLs that serve the real LFS content directlyTest plan
/docs/mcp-server🤖 Generated with Claude Code